Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate PING on connect option #965

Closed
mp911de opened this issue Jan 12, 2019 · 0 comments
Closed

Deprecate PING on connect option #965

mp911de opened this issue Jan 12, 2019 · 0 comments
Labels
type: feature A new feature
Milestone
5.2.0

Comments

@mp911de
Copy link
Collaborator

mp911de commented Jan 12, 2019

Having a handshake procedure in place (see #964) we no longer require this options. We should deprecate PING on connecting in favor of the handshake procedure with RESP3.
@mp911de mp911de added this to the 5.2.0 milestone Jan 12, 2019
@mp911de mp911de mentioned this issue Jan 12, 2019
Closed
mp911de added a commit that referenced this issue Apr 18, 2019
@mp911de
Deprecate ClientOptions.pingBeforeActivateConnection(…) #965
b6de74e 
With migrating towards RESP3 and the connection handshake we're going to remove PING before connection activation in Lettuce 6. Deprecating methods prior removal.
@mp911de mp911de closed this as completed Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: feature A new feature
Projects
None yet
Milestone
5.2.0
Development

No branches or pull requests
1 participant
@mp911de