Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce adaptive trigger event #952

Closed
mp911de opened this issue Jan 2, 2019 · 2 comments
Closed

Introduce adaptive trigger event #952

mp911de opened this issue Jan 2, 2019 · 2 comments
Labels
type: feature A new feature
Milestone

Comments

@mp911de
Copy link
Collaborator

mp911de commented Jan 2, 2019

Feature Request

RedisClusterClient should emit an event via EventBus if an adaptive refresh is triggered so adaptive triggers can be used outside of the client itself to perform an e.g. delayed topology refresh.

Is your feature request related to a problem? Please describe

See #672, in which topology updates are performed later than the adaptive trigger is consumed (Lettuce is updating faster the topology than Redis is performing the topology change).

Describe the solution you'd like

A clear and concise description of what you want to happen. Add any considered drawbacks.

Describe alternatives you've considered

Introducing delays but that doesn't seem to be a good fit as it introduces another layer of guesswork.

@mp911de mp911de added the type: feature A new feature label Jan 2, 2019
mp911de added a commit that referenced this issue Jan 2, 2019
Topology refresh scheduling by an adaptive trigger now emits a AdaptiveRefreshTriggeredEvent that allows applications to get notified about an adaptive refresh so application can track the state of the topology view and potentially register another topology update.
@mp911de mp911de added this to the 5.2.0 milestone Jan 2, 2019
@mp911de
Copy link
Collaborator Author

mp911de commented Jan 2, 2019

That's implemented now.

@mp911de mp911de closed this as completed Jan 2, 2019
@SushmaReddyLoka
Copy link

SushmaReddyLoka commented Aug 17, 2020

How can one delay topology refresh by subscribing to this event ? Because the refresh is already done and then the event is published right ? Are we expecting to reloadpartitions again () as part of this event , probably by scheduling the reloadparitions() for some time in future ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature A new feature
Projects
None yet
Development

No branches or pull requests

2 participants