Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support geo commands in lettuce 3.3 #86

Closed
mp911de opened this issue Jun 23, 2015 · 2 comments
Closed

Support geo commands in lettuce 3.3 #86

mp911de opened this issue Jun 23, 2015 · 2 comments
Labels
type: feature A new feature
Milestone
Lettuce 3.3

Comments

@mp911de
Copy link
Collaborator

mp911de commented Jun 23, 2015

Support commands

  • geoadd
  • georadius
  • georadiusbymember
  • geoencode
  • geodecode

in lettuce 3.3
@mp911de mp911de added this to the Lettuce 3.3 milestone Jun 23, 2015
@mp911de mp911de added the type: feature A new feature label Jun 23, 2015
mp911de added a commit that referenced this issue Jun 23, 2015
@mp911de
Support geo commands in lettuce 3.3 #86
8e71ec0
mp911de added a commit that referenced this issue Jun 23, 2015
@mp911de
Documentation for geo commands #86
bd66695 
More javadocs for the API
mp911de added a commit that referenced this issue Jun 28, 2015
@mp911de
Adopt API change of lat/long to long/lat #86
173ffbb
@mp911de
Copy link
Collaborator Author

mp911de commented Jun 29, 2015

  • geodist
  • geopos

@mp911de
Copy link
Collaborator Author

mp911de commented Jun 29, 2015

Added GeoTuple type to represent x,y coordinates. georadius commands return a mixed list of string, double/integer and x,y positions (not GeoTuples) because of the dynamic parameters. A future enhancement could be:

  • either a parser with model
  • or methods without the possibility to select withdist, withhash and withcoord but providing a nice data structure containing all with details.

mp911de added a commit that referenced this issue Jun 29, 2015
@mp911de
Support geopos and geodist #86
dd9c473 
This commit also adds the GeoTuple type. It's a half geo location, because the altitude is missing, but open for future extension. geodecode, geoencode and geopos commands use GeoTuple in their responses.
mp911de added a commit that referenced this issue Jul 1, 2015
@mp911de
Polishing Geo-API #86
dcf8e91 
- Use GeoWithin type for georadius
- Use GeoEncoded type for geoencode/geodecode
- Rename GeoTuple to GeoCoordinates to reflect the purpose
- API documentation
- Test against redis unstable branch

Motivation: The interface containing List of Objects or List of Lists of Objects makes it hard to use the Geo API, especially when the coordinates are provided as strings. GeoWithin and GeoEncoded reflect the data structures returned by Redis and allow operations in a convenient way.
@mp911de mp911de closed this as completed Jul 1, 2015
mp911de added a commit that referenced this issue Jul 6, 2015
@mp911de
Fix bug in GeoCoordinates.toString and extend tests #86
c3588d7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: feature A new feature
Projects
None yet
Milestone
Lettuce 3.3
Development

No branches or pull requests
1 participant
@mp911de