Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure Master/Slave topology refresh connections are closed #723

Closed
mp911de opened this issue Mar 6, 2018 · 0 comments
Closed

Ensure Master/Slave topology refresh connections are closed #723

mp911de opened this issue Mar 6, 2018 · 0 comments
Labels
type: bug A general bug
Milestone
Lettuce 5.1.0 M1

Comments

@mp911de
Copy link
Collaborator

mp911de commented Mar 6, 2018

Similar issue to #721, Connections.closeAsync(…) can cause open connections as Connections.onAccept(…) does not consider an open/closed state.
@mp911de mp911de added the type: bug A general bug label Mar 6, 2018
@mp911de mp911de added this to the Lettuce 5.1.0 milestone Mar 6, 2018
mp911de added a commit that referenced this issue Mar 6, 2018
@mp911de
Ensure Master/Slave topology refresh connections are closed after tim…
0ae34d4 
…eout #723

Lettuce now closes Master/Slave topology refresh connections if connections complete the connect progress after the actual refresh finishes. This could happen if a connection finished its connect (slow connect) after the synchronization timeout and after all topology views were obtained so the process already ran its cleanup.
@mp911de mp911de closed this as completed Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug A general bug
Projects
None yet
Milestone
Lettuce 5.1.0 M1
Development

No branches or pull requests
1 participant
@mp911de