-
Notifications
You must be signed in to change notification settings - Fork 986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use dedicated string codecs on String connections and add ByteArrayCodec #70
Comments
performance will be better , codec will be done by user-thread insteadof netty-thread. |
It's a bit different. Performance depends on how the codec works internally. If you work with one connection only (does not matter whether single- or multi-threaded), you won't notice a difference. The String encoding is non-blocking, the String decoding is blocking. But even this has very little effect, since Redis works mostly single-threaded. You'll get benefits if you connect to multiple Redis instances. Multiple connections won't share a codec and won't block each other. The change is from share the String codec amongst the whole client to share the String codec amongst a logical connection. A logical connection is either a sync/async connection to Redis Standalone/Sentinel or a connection to a whole cluster. The cluster connection consists of multiple connections behind the scenes. So here the String codec is shared again among multiple physical Redis instances. |
The text was updated successfully, but these errors were encountered: