Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recovered Sentinels in Master/Slave not reconnected #668

Closed
mp911de opened this issue Dec 13, 2017 · 0 comments
Closed

Recovered Sentinels in Master/Slave not reconnected #668

mp911de opened this issue Dec 13, 2017 · 0 comments
Labels
type: bug A general bug
Milestone
Lettuce 4.4.3

Comments

@mp911de
Copy link
Collaborator

mp911de commented Dec 13, 2017

Adding a new Sentinel server is not considered to connect when using MasterSlave. The acual SentinelReconnectMessagePredicate mixes up argument order (is: message, channel, should be: channel, message).
@mp911de mp911de added the type: bug A general bug label Dec 13, 2017
@mp911de mp911de added this to the Lettuce 4.4.3 milestone Dec 13, 2017
mp911de added a commit that referenced this issue Dec 13, 2017
@mp911de
Fix argument order for Sentinel-related Pub/Sub messages in Master/Sl…
b2cbefc 
…ave #668

Lettuce now evaluates the correct message and channel arguments to determine whether it should refresh/reconnect sentinels.
mp911de added a commit that referenced this issue Dec 13, 2017
@mp911de
Fix argument order for Sentinel-related Pub/Sub messages in Master/Sl…
8e79e04 
…ave #668

Lettuce now evaluates the correct message and channel arguments to determine whether it should refresh/reconnect sentinels.
mp911de added a commit that referenced this issue Dec 13, 2017
@mp911de
Fix argument order for Sentinel-related Pub/Sub messages in Master/Sl…
089b3c4 
…ave #668

Lettuce now evaluates the correct message and channel arguments to determine whether it should refresh/reconnect sentinels.
@mp911de mp911de changed the title Newly added Sentinels in Master/Slave not recognized Recovered Sentinels in Master/Slave not reconnected Dec 13, 2017
@mp911de mp911de closed this as completed Dec 13, 2017
mp911de added a commit that referenced this issue Dec 18, 2017
@mp911de
Fix argument order for Sentinel-related Pub/Sub messages in Master/Sl…
0a342ec 
…ave #668

Lettuce now evaluates the correct message and channel arguments to determine whether it should refresh/reconnect sentinels.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug A general bug
Projects
None yet
Milestone
Lettuce 4.4.3
Development

No branches or pull requests
1 participant
@mp911de