Misleading wasRolledBack method

[graineri]

This only applies to Lettuce 5.x.

Taking a look at TransactionResult interface I noticed there is a wasRolledBack method which I find somewhat misleading since there is no such thing in Redis.

I finally realized the intent of this method once I read TransactionCommandTest: it actually means that the transaction was discarded (this behavior is explained here).

[mp911de]

Agree. Was rolled back would make up a much better name. I’d add a delegation and deprecate the current method. Am 7. Dez. 2017, 13:03 -0800 schrieb Gabriel Raineri <[email protected]>:

…

This only applies to Lettuce 5.x. Taking a look at TransactionResult interface I noticed there is a wasRolledBack method which I find somewhat misleading since there is no such thing in Redis. I finally realized the intent of this method once I read TransactionCommandTest: it actually means that the transaction was discarded (this behavior is explained here). — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[mp911de]

That's fixed now.