Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Asynchronous connection initialization #640

Closed
mp911de opened this issue Nov 6, 2017 · 0 comments
Closed

Asynchronous connection initialization #640

mp911de opened this issue Nov 6, 2017 · 0 comments
Labels
type: feature A new feature
Milestone
Lettuce 5.1.0 M1

Comments

@mp911de
Copy link
Collaborator

mp911de commented Nov 6, 2017

Lettuce should internally not block when establishing a connection. This especially applies to connections that perform multiple connection attempts (Sentinel, Cluster). It should be also possible to close a connection asynchronously.
@mp911de mp911de added the type: feature A new feature label Nov 6, 2017
@mp911de mp911de added this to the Lettuce 5.1.0 milestone Nov 6, 2017
mp911de added a commit that referenced this issue Nov 7, 2017
@mp911de
Refactor to asynchronous connect #640
8cfb2e8 
Lettuce now uses fully asynchronous connects for initial connection, address resolution and Sentinel/Redis Cluster connect. This change eliminates all blocking bits in the connection initialization for:

* Redis Standalone
* Redis Pub/Pub
* Redis Sentinel (not Master/Slave)
* Redis Cluster
* Redis Cluster Pub/Sub

RedisClusterClient now also exposes connectAsync(…) and connect connectPubSubAsync(…). Connection disposal also exposes asynchronous methods via closeAsync() returning a CompletableFuture.
@mp911de mp911de closed this as completed Nov 7, 2017
mp911de added a commit that referenced this issue Nov 11, 2017
@mp911de
Close async closeables asynchronously #640
7118b2f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: feature A new feature
Projects
None yet
Milestone
Lettuce 5.1.0 M1
Development

No branches or pull requests
1 participant
@mp911de