Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command.isDone() not consistent with CompletableFuture.isDone() #629

Closed
mp911de opened this issue Oct 17, 2017 · 0 comments
Closed

Command.isDone() not consistent with CompletableFuture.isDone() #629

mp911de opened this issue Oct 17, 2017 · 0 comments
Labels
type: bug A general bug
Milestone
Lettuce 4.4.2

Comments

@mp911de
Copy link
Collaborator

mp911de commented Oct 17, 2017

Command.isDone() reports false if it is cancelled whileCompletableFuture.isDone() reports true for cancelled.
@mp911de mp911de added the type: bug A general bug label Oct 17, 2017
@mp911de mp911de added this to the Lettuce 4.4.2 milestone Oct 17, 2017
mp911de added a commit that referenced this issue Oct 17, 2017
@mp911de
Report done status for Command.isDone() if command was canceled #629
12a0d6f
mp911de added a commit that referenced this issue Oct 17, 2017
@mp911de
Polishing #629
aaef4b4
mp911de added a commit that referenced this issue Oct 17, 2017
@mp911de
Report done status for Command.isDone() if command was canceled #629
38d7a7e
mp911de added a commit that referenced this issue Oct 17, 2017
@mp911de
Polishing #629
0adcf82
mp911de added a commit that referenced this issue Oct 17, 2017
@mp911de
Report done status for Command.isDone() if command was canceled #629
ae142f3
mp911de added a commit that referenced this issue Oct 17, 2017
@mp911de
Polishing #629
37c9f14
mp911de added a commit that referenced this issue Oct 17, 2017
@mp911de
Report done status for Command.isDone() if command was canceled #629
a7ec7db
mp911de added a commit that referenced this issue Oct 17, 2017
@mp911de
Polishing #629
0e698e9
@mp911de mp911de closed this as completed Oct 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug A general bug
Projects
None yet
Milestone
Lettuce 4.4.2
Development

No branches or pull requests
1 participant
@mp911de