Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConnectionWatchdog should be the last handler #335

Closed
mp911de opened this issue Aug 17, 2016 · 0 comments
Closed

ConnectionWatchdog should be the last handler #335

mp911de opened this issue Aug 17, 2016 · 0 comments
Milestone
Lettuce 4.2.2

Comments

@mp911de
Copy link
Collaborator

mp911de commented Aug 17, 2016 •
edited
Loading

The reuse of handlers causes multiple calls to channelActive/channelInactive/and so on. In some cases, the reconnection is faster than channel deregistration (calls to channelUnregistered) which leads to the call sequence channelRegistered (new channel), channelUnregistered (old channel). Similar for channelActive/channelInactive. This is handled inside the CommandHandler but can still lead to issues. Moving the ConnectionWatchdog to the end reduces the probability of the calls coming in the wrong order. It also fixes the channelActive/channelInactive order in fast reconnect scenarios as the channelInactive call is done before notifying the ConnectionWatchdog.
@mp911de mp911de added this to the Lettuce 4.2.2 milestone Aug 17, 2016
mp911de added a commit that referenced this issue Aug 17, 2016
@mp911de
Add ConnectionWatchdog as last handler #335
646115c 
The reuse of handlers causes multiple calls to channelActive/channelInactive/and so on. In some cases, the reconnection is faster than channel deregistration (calls to channelUnregistered) which leads to the call sequence channelRegistered (new channel), channelUnregistered (old channel). Similar for channelActive/channelInactive. This is handled inside the CommandHandler but can still lead to issues. Moving the ConnectionWatchdog to the end reduces the probability of the calls coming in the wrong order. It fixes also the channelActive/channelInactive order in fast reconnect scenarios as the channelInactive call is done before notifying the ConnectionWatchdog.
mp911de added a commit that referenced this issue Aug 17, 2016
@mp911de
Add ConnectionWatchdog as last handler #335
ae70102 
The reuse of handlers causes multiple calls to channelActive/channelInactive/and so on. In some cases, the reconnection is faster than channel deregistration (calls to channelUnregistered) which leads to the call sequence channelRegistered (new channel), channelUnregistered (old channel). Similar for channelActive/channelInactive. This is handled inside the CommandHandler but can still lead to issues. Moving the ConnectionWatchdog to the end reduces the probability of the calls coming in the wrong order. It fixes also the channelActive/channelInactive order in fast reconnect scenarios as the channelInactive call is done before notifying the ConnectionWatchdog.
@mp911de mp911de closed this as completed Aug 17, 2016
@mp911de mp911de mentioned this issue Aug 25, 2016
Closed
3 tasks
@mors741 mors741 mentioned this issue Sep 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Lettuce 4.2.2
Development

No branches or pull requests
1 participant
@mp911de