Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CommandHandler notifications called out of order #315

Closed
mp911de opened this issue Jul 23, 2016 · 1 comment
Closed

CommandHandler notifications called out of order #315

mp911de opened this issue Jul 23, 2016 · 1 comment
Labels
type: bug A general bug
Milestone

Comments

@mp911de
Copy link
Collaborator

mp911de commented Jul 23, 2016

In some cases, event notifications for reconnection CommandHandler are called out-of-order.

Adding a command handler id makes visible what's going on:

  1. The channel is deactivated
  2. The channel is reconnected
  3. The channel receives an activation
  4. The channel is unregistered (notification from the previous channel I/O)
2016-07-23 20:58:54 [DEBUG] [lettuce-nioEventLoop-6-1] [CommandHandlerId 0x31e, /127.0.0.1:36367 -> localhost/127.0.0.1:6479] deactivating channel handler (CommandHandler:708)
2016-07-23 20:58:54 [DEBUG] [lettuce-nioEventLoop-6-2] [CommandHandlerId 0x31e, (inactive)] channelRegistered() (CommandHandler:113)
2016-07-23 20:58:54 [DEBUG] [lettuce-nioEventLoop-6-2] [CommandHandlerId 0x31e, /127.0.0.1:36371 -> localhost/127.0.0.1:6479] channelActive() (CommandHandler:583)
2016-07-23 20:58:54 [DEBUG] [lettuce-nioEventLoop-6-1] [CommandHandlerId 0x31e, /127.0.0.1:36371 -> localhost/127.0.0.1:6479] channelInactive() done (CommandHandler:733)
2016-07-23 20:58:54 [DEBUG] [lettuce-nioEventLoop-6-1] [CommandHandlerId 0x31e, /127.0.0.1:36371 -> localhost/127.0.0.1:6479] channelUnregistered()
@mp911de mp911de added the type: bug A general bug label Jul 23, 2016
@mp911de mp911de added this to the Lettuce 4.2.2 milestone Jul 23, 2016
mp911de added a commit that referenced this issue Jul 24, 2016
Discard out-of-order events for disconnected/reconnected connections if inactive/unregister events arrive after register/active events of a reconnect. Allocate temporary buffer upon channel-handler initialization and do not remove the buffer until the channel is closed.
mp911de added a commit that referenced this issue Jul 24, 2016
Discard out-of-order events for disconnected/reconnected connections if inactive/unregister events arrive after register/active events of a reconnect. Allocate temporary buffer upon channel-handler initialization and do not remove the buffer until the channel is closed.
mp911de added a commit that referenced this issue Jul 24, 2016
Discard out-of-order events for disconnected/reconnected connections if inactive/unregister events arrive after register/active events of a reconnect. Allocate temporary buffer upon channel-handler initialization and do not remove the buffer until the channel is closed.
mp911de added a commit that referenced this issue Jul 24, 2016
Discard out-of-order events for disconnected/reconnected connections if inactive/unregister events arrive after register/active events of a reconnect. Allocate temporary buffer upon channel-handler initialization and do not remove the buffer until the channel is closed.
@mp911de
Copy link
Collaborator Author

mp911de commented Jul 24, 2016

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

No branches or pull requests

1 participant