-
Notifications
You must be signed in to change notification settings - Fork 987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SPUBLISH not working for Reactive/Coroutines client when using pubsub connection #2971
Comments
This was referenced Aug 22, 2024
opened a PR fixing this typo |
jkrauze
changed the title
SPUBLISH not working for Reactive/Coroutines client
SPUBLISH not working for Reactive/Coroutines client when using pubsub connection
Aug 22, 2024
Wondering why the integration tests have not caught this issue. Please, give me a little time to verify that. |
tishun
pushed a commit
that referenced
this issue
Aug 25, 2024
Well the answer is we did not have tests for that :/ |
tishun
pushed a commit
to tishun/lettuce-core
that referenced
this issue
Aug 26, 2024
4 tasks
tishun
added a commit
that referenced
this issue
Aug 26, 2024
fixing #2971 Co-authored-by: Jedrzej Krauze <[email protected]>
@jkrauze thank you for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug Report
https://github.com/redis/lettuce/pull/2838/files#r1727231070
As per comment I left on that PR, the
spublish()
command inRedisPubSubReactiveCommandsImpl
points topublish
command instead ofspublish
.This causes
spublish()
command to point to a wrong underlying command when using a pubsub connection (initiated with.connectPubSub()
method).Please note that the
spublish()
works fine when we use a regular connection.Current Behavior
this calls
PUBLISH test test
this calls
SPUBLISH test test
Expected behavior/code
both should call
SPUBLISH test test
Environment
Possible Solution
correct the typo
Additional context
The text was updated successfully, but these errors were encountered: