Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMISMEMBER is not marked a readonly command #2197

Closed
lorenzhawkes opened this issue Sep 20, 2022 · 1 comment
Closed

SMISMEMBER is not marked a readonly command #2197

lorenzhawkes opened this issue Sep 20, 2022 · 1 comment
Labels
type: bug A general bug

Comments

@lorenzhawkes
Copy link
Contributor

Bug Report

Current Behavior

When issuing a SMISMEMBER command, the master node is always picked when ReadFrom.REPLICA is set.

Input Code

val connection = MasterReplica.connect(redisClient, StringCodec.UTF8, uris) // master and replica uris
connection.setReadFrom(ReadFrom.REPLICA)
val async = connection.async()
connection.smismember("key", "value1", "value2")

Expected behavior/code

One of the relica nodes should get the command.

Environment

  • Lettuce version(s): 6.2.0.RELEASE
  • Redis version: 6.2.6

Possible Solution

io.lettuce.core.masterreplica.ReadOnlyCommands should contain SMISMEMBER
and
io.lettuce.core.cluster.ReadOnlyCommands should contain SMISMEMBER

lorenzhawkes pushed a commit to lorenzhawkes/lettuce-core that referenced this issue Sep 20, 2022
lorenzhawkes pushed a commit to lorenzhawkes/lettuce-core that referenced this issue Sep 20, 2022
@mp911de mp911de added the type: bug A general bug label Sep 20, 2022
mp911de pushed a commit that referenced this issue Sep 26, 2022
Original pull request: #2198

Co-authored-by: Lorenz Bateman <[email protected]>
mp911de pushed a commit that referenced this issue Sep 26, 2022
Original pull request: #2198

Co-authored-by: Lorenz Bateman <[email protected]>
@mp911de
Copy link
Collaborator

mp911de commented Sep 26, 2022

Fixed via #2198

@mp911de mp911de closed this as completed Sep 26, 2022
@mp911de mp911de added this to the 6.2.1.RELEASE milestone Sep 26, 2022
@mp911de mp911de modified the milestones: 6.2.1.RELEASE, 6.1.10.RELEASE Oct 7, 2022
mp911de pushed a commit that referenced this issue Oct 7, 2022
Original pull request: #2198

Co-authored-by: Lorenz Bateman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

No branches or pull requests

2 participants