Let nullable ScoredValue factory methods return Value<V> instead of ScoredValue<V> #1644
Labels
Milestone
Comments
mp911de
changed the title
mp911de
added a commit
that referenced
this issue
Mar 5, 2021
GeoValue provides now from and fromNullable methods returning Value. Empty values should not be associated with coordinates. Value now exposes isEmpty() and ifHasValueOrElse(…) methods to improve functional programming arrangements.
mp911de
added a commit
that referenced
this issue
Mar 5, 2021
…coredValue<V> #1644 Nullable ScoredValue factory methods now declare Value as return type as an empty value cannot be associated without a score. Either both pieces of information should be present or absent but partial existence doesn't fit the programming model.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Having an empty
ScoredValuedoesn't make sense as it cannot be persisted nor it makes sense to construct it by a user as the scored value is always associated with a score. Instead, an emptyScoredValueshould just return an empty value.In that scope, we should revisit the nullable factory methods of
GeoValue, whether a nullableGeoValue.fromNullableshould be introduced with a return type ofValue<V>to indicate it can be either a presentGeoValue<V>or an absentValue<V>.The text was updated successfully, but these errors were encountered: