Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly report isDone if Command completed with completeExceptionally #1433

Closed
mp911de opened this issue Sep 28, 2020 · 0 comments
Closed

Correctly report isDone if Command completed with completeExceptionally #1433

mp911de opened this issue Sep 28, 2020 · 0 comments
Labels
type: task A general task
Milestone
6.0.0

Comments

@mp911de
Copy link
Collaborator

mp911de commented Sep 28, 2020

Right now, a plain Command reports isDone() == false when completed exceptionally. We should for consistency report correctly the done flag.
@mp911de mp911de added the type: task A general task label Sep 28, 2020
@mp911de mp911de added this to the 6.0.0 milestone Sep 28, 2020
mp911de added a commit that referenced this issue Sep 28, 2020
@mp911de
Correctly report isDone if Command completed with completeExceptionally
b6ca25e 
#1433
mp911de added a commit that referenced this issue Sep 28, 2020
@mp911de
Polishing #1433
fd4dea4 
Tweak Javadoc.
mp911de added a commit that referenced this issue Sep 28, 2020
@mp911de
Correctly report isDone if Command completed with completeExceptionally
811789b 
#1433
mp911de added a commit that referenced this issue Sep 28, 2020
@mp911de
Polishing #1433
0268655 
Tweak Javadoc.
@mp911de mp911de closed this as completed Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: task A general task
Projects
None yet
Milestone
6.0.0
Development

No branches or pull requests
1 participant
@mp911de