Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Java Flight Recorder #1430

Closed
mp911de opened this issue Sep 28, 2020 · 1 comment
Closed

Add support for Java Flight Recorder #1430

mp911de opened this issue Sep 28, 2020 · 1 comment
Labels
type: feature A new feature
Milestone
6.1 RC1

Comments

@mp911de
Copy link
Collaborator

mp911de commented Sep 28, 2020

It would make sense to emit JFR events for easier tracing. Candidates for events are:

  • Command sent/completed/failed (error response, timeout exception, cancel)
  • Command retry in Redis Cluster
  • Cluster Topology changed
  • Cluster Topology refresh started/finished
  • Master/Replicat Topology changes
@mp911de mp911de added the type: task A general task label Sep 28, 2020
@mp911de mp911de added this to the 6.1 M1 milestone Sep 28, 2020
@mp911de mp911de changed the title Investigate support for Java Flight Recorder Evens Investigate support for Java Flight Recorder Events Sep 28, 2020
@mp911de mp911de modified the milestones: 6.1 M1, 6.1 M2 Jan 8, 2021
@mp911de mp911de added type: feature A new feature and removed type: task A general task labels Mar 9, 2021
@mp911de mp911de changed the title Investigate support for Java Flight Recorder Events Add support for Java Flight Recorder Mar 9, 2021
@mp911de
Copy link
Collaborator Author

mp911de commented Mar 9, 2021

The initial support is:

  • Connection events (creation, connected/disconnected, connection activated/deactivated)
  • Cluster events (Moved/Ask redirections, Topology updates)
  • Master/Replica events (Topology updates)

mp911de added a commit that referenced this issue Mar 9, 2021
@mp911de
Add support for Java Flight Recorder #1430
1241b10 
Lettuce now emits events to Java Flight Recorder through the EventRecorder abstraction that adopts Lettuce Events into JFR Events.

The following event types are emitted:

* Connection events (creation, connected/disconnected, connection activated/deactivated)
* Cluster events (Moved/Ask redirections, Topology updates)
* Master/Replica events (Topology updates)
@mp911de mp911de closed this as completed Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: feature A new feature
Projects
None yet
Milestone
6.1 RC1
Development

No branches or pull requests
1 participant
@mp911de