Redesign command latency metrics publishing #1409
Labels
Milestone
Comments
mp911de
added
type: task
mp911de
added a commit
that referenced
this issue
Sep 10, 2020
Command latency metric collection uses now CommandLatencyRecorder which is a simplified variant of CommandLatencyCollector exposing isEnabled() and recordCommandLatency(…) methods. Latency metrics are now less tied to how latencies are published/surfaced. The publishing mechanism checks whether the configured CommandLatencyRecorder collects and exposes metrics so the publisher can obtain the collected metrics. Using a latency recorder that don't expose metrics through CommandLatencyRecorder will leave latency metrics event publication disabled. This is a breaking changes as several methods were renamed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now, Lettuce defines a
MetricCollectorand aMetricEventPublisherwhich assumes a certain distribution and collection model for command latency metrics. When considering a Micrometer integration (#795), this model isn't applicable as Micrometer is the facility that encapsulates both aspects.We should change
CommandLatencyCollectorto no longer assume metric collection on the interface level (MetricCollector.retrieveMetrics()) but make metric event publication an implementation detail ofDefaultCommandLatencyCollector.EventPublisherOptions commandLatencyPublisherOptions(fromClientResources) would become also a part ofDefaultCommandLatencyCollector.The text was updated successfully, but these errors were encountered: