Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RedisURI builder .withAuthentication(…) should accept char[] as password to align with withPassword(char[]) #1404

Closed
mp911de opened this issue Sep 1, 2020 · 0 comments
Closed

RedisURI builder .withAuthentication(…) should accept char[] as password to align with withPassword(char[]) #1404

mp911de opened this issue Sep 1, 2020 · 0 comments
Labels
type: feature A new feature
Milestone
6.0.0 RC2

Comments

@mp911de
Copy link
Collaborator

mp911de commented Sep 1, 2020

No description provided.

@mp911de mp911de added the type: feature A new feature label Sep 1, 2020
@mp911de mp911de added this to the 6.0.0 milestone Sep 1, 2020
mp911de added a commit that referenced this issue Sep 1, 2020
@mp911de
Introduce apply methods for SSL and authentication settings #1406 #1404
969135b 
RedisURI and its builder now expose methods to apply authentication and SSL settings from a source RedisURI. It is also possible to initialize a RedisURI builder from an existing RedisURI to copy settings.

Previously, several places applied seed/connection settings individually which caused bugs when new properties were introduced. Pulling initialization any apply methods into RedisURI avoids sprawl of code duplicates that evolved differently.
@mp911de mp911de closed this as completed Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: feature A new feature
Projects
None yet
Milestone
6.0.0 RC2
Development

No branches or pull requests
1 participant
@mp911de