Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RedisAdvancedClusterAsyncCommandsImpl scriptKill is incorrectly calling scriptFlush #1340

Closed
azhukayak opened this issue Jul 10, 2020 · 2 comments
Closed

RedisAdvancedClusterAsyncCommandsImpl scriptKill is incorrectly calling scriptFlush #1340

azhukayak opened this issue Jul 10, 2020 · 2 comments
Labels
type: bug A general bug
Milestone
5.3.2

Comments

@azhukayak
Copy link

While reading some of the implementation just notice that the scriptKill method is actually doing a scriptFlush command instead. That's probably not the intention?

https://github.com/lettuce-io/lettuce-core/blob/dbab9668c379f7931b1e2d50dbb232d4823abea9/src/main/java/io/lettuce/core/cluster/RedisAdvancedClusterAsyncCommandsImpl.java#L418
@dengliming dengliming mentioned this issue Jul 12, 2020
Closed
4 tasks
@dengliming
Copy link
Contributor

You were right. I think it's a bug. fixed #1341

@mp911de mp911de added the type: bug A general bug label Jul 13, 2020
@mp911de mp911de added this to the 5.3.2 milestone Jul 13, 2020
mp911de pushed a commit that referenced this issue Jul 13, 2020
@dengliming @mp911de
RedisAdvancedClusterAsyncCommands.scriptKill now calls scriptKill ins…
79ea527 
…tead of scriptFlush #1341

Original pull request: #1340.
mp911de added a commit that referenced this issue Jul 13, 2020
@mp911de
Polishing #1340
a273e29 
scriptKill on the reactive Cluster API now correctly calls scriptKill instead of scriptFlush. Fix test.

Original pull request: #1341
mp911de pushed a commit that referenced this issue Jul 13, 2020
@dengliming @mp911de
RedisAdvancedClusterAsyncCommands.scriptKill now calls scriptKill ins…
32e17ba 
…tead of scriptFlush #1341

Original pull request: #1340.
mp911de added a commit that referenced this issue Jul 13, 2020
@mp911de
Polishing #1340
4ea43dc 
scriptKill on the reactive Cluster API now correctly calls scriptKill instead of scriptFlush. Fix test.

Original pull request: #1341
@mp911de
Copy link
Collaborator

mp911de commented Jul 13, 2020

That's fixed now. Thanks for the report.

@mp911de mp911de closed this as completed Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug A general bug
Projects
None yet
Milestone
5.3.2
Development

No branches or pull requests
3 participants
@mp911de @dengliming @azhukayak