Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEOADD passes long/lat parameters in the wrong order to Redis #134

Closed
IdanFridman opened this issue Sep 9, 2015 · 4 comments
Closed

GEOADD passes long/lat parameters in the wrong order to Redis #134

IdanFridman opened this issue Sep 9, 2015 · 4 comments
Assignees
Labels
type: bug A general bug
Milestone

Comments

@IdanFridman
Copy link

Redis GEOADD API expecting latitude,longitude (with that order)

Lettuce API has the opposite order:
RedisFuture geoadd(K key, double longitude, double latitude, V member);

Thanks,
Idan.

@mp911de mp911de added the type: bug A general bug label Sep 9, 2015
@mp911de mp911de added this to the Lettuce 3.4 milestone Sep 9, 2015
@mp911de
Copy link
Collaborator

mp911de commented Sep 9, 2015

Affected versions: 3.3, 3.4 and 4.0

@mp911de mp911de self-assigned this Sep 9, 2015
@mp911de
Copy link
Collaborator

mp911de commented Sep 9, 2015

It's actually the other way round. Redis expects longitude latitude (see http://redis.io/commands/geoadd). The API has the correct signature, but the values are passed in the wrong order towards Redis. The parameter order was switched during the Geo API development (see redis/redis#2705). In contrast to the current impl, Matt's implementation used latitude longitude.

@mp911de mp911de changed the title Bug within Geo API commands GEOADD passes long/lat parameters in the wrong order to Redis Sep 9, 2015
@mp911de mp911de modified the milestones: Lettuce 3.3, Lettuce 3.4 Sep 10, 2015
@mp911de
Copy link
Collaborator

mp911de commented Sep 10, 2015

Fixed 4.0-SNAPSHOT available on https://oss.sonatype.org/content/repositories/snapshots/

@mp911de mp911de closed this as completed Sep 10, 2015
@IdanFridman
Copy link
Author

Thank you.

2015-09-10 8:46 GMT+03:00 Mark Paluch [email protected]:

Closed #134 https://github.com/mp911de/lettuce/issues/134.


Reply to this email directly or view it on GitHub
https://github.com/mp911de/lettuce/issues/134#event-405581613.

@mp911de mp911de modified the milestones: 3.3.1.Final, Lettuce 3.3 Sep 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

No branches or pull requests

2 participants