Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce RedisStateMachine bytecode size #1332

Closed
hellyguo opened this issue Jul 4, 2020 · 1 comment
Closed

Reduce RedisStateMachine bytecode size #1332

hellyguo opened this issue Jul 4, 2020 · 1 comment
Labels
type: feature A new feature
Milestone
6.0 RC1

Comments

@hellyguo
Copy link
Contributor

hellyguo commented Jul 4, 2020

code like #1323 , I want to merge request to branch main.
A bit more: because method getType's switch cases is more complex than branch 5.3.x(5 cases), I refactored it. Waste a little runtime memory to speed up runtime speed.

As I know, cases less than 5 is work fine. But, the more, the worse.
@hellyguo hellyguo added the type: feature A new feature label Jul 4, 2020
@hellyguo hellyguo mentioned this issue Jul 4, 2020
Closed
@mp911de mp911de added this to the 6.0 RC1 milestone Jul 9, 2020
mp911de pushed a commit that referenced this issue Jul 9, 2020
@hellyguo @mp911de
Reduce RedisStateMachine bytecode size to optimize for JIT inlining #…
49a5b52 
…1332

Also, use a little runtime memory to speed up runtime speed.

Original pull request: #1333
mp911de added a commit that referenced this issue Jul 9, 2020
@mp911de
Polishing #1332
0071005 
Use loop to populate type lookup. Reformat code.

Original pull request: ##1333
@mp911de
Copy link
Collaborator

mp911de commented Jul 9, 2020

Merged via #1033

@mp911de mp911de closed this as completed Jul 9, 2020
@mp911de mp911de changed the title reduce method(decode)'s bytecode size Reduce RedisStateMachine bytecode size Jul 9, 2020
mp911de added a commit that referenced this issue Jul 9, 2020
@mp911de
Polishing #1332
c3d997d 
Increase method visibility to avoid synthetic stack frames. Exclude BYTES type from type discovery.

Original pull request: #1333
mp911de added a commit that referenced this issue Jul 17, 2020
@mp911de
Fix VERBATIM_STRING decoding #1332
b416bad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: feature A new feature
Projects
None yet
Milestone
6.0 RC1
Development

No branches or pull requests
2 participants
@mp911de @hellyguo