Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stream commands are not considered for ReadOnly routing #1271

Closed
redviper opened this issue Apr 20, 2020 · 1 comment
Closed

Stream commands are not considered for ReadOnly routing #1271

redviper opened this issue Apr 20, 2020 · 1 comment
Labels
type: bug A general bug
Milestone
5.3.0

Comments

@redviper
Copy link

Bug Report

Redis Stream based commands are not considered for Read-Only routing.

Checked with @mp911de and he verified the issue.

Current Behavior

When using a Replica setup using ElastiCache clustered-mode, all xread commands are routed to the Master.

Input Code

        Flux.just(partitions.toArray(new String[0]))
                .flatMap(s -> Flux.just(XReadArgs.StreamOffset.from(key, "0-0")))
                .flatMap(streamOffset -> cmd.xread(streamOffset))
                .retry()

Expected behavior/code

Environment

  • Lettuce version(s): [ 5.0.0.RELEASE]
  • Redis version: [5.0.6]

Possible Solution

Stream read-only commands should correctly pick a destination by using the ReadFrom configurationn.
@redviper redviper added the type: bug A general bug label Apr 20, 2020
@mp911de mp911de added this to the 5.3.0 milestone Apr 20, 2020
mp911de added a commit that referenced this issue Apr 23, 2020
@mp911de
Enable Stream commands for read-only routing #1271
f812f64 
XINFO, XLEN, XPENDING, XRANGE, XREVRANGE, and XREAD can now be issued to replicas.
mp911de added a commit that referenced this issue Apr 23, 2020
@mp911de
Enable Stream commands for read-only routing #1271
7fbf9cb 
XINFO, XLEN, XPENDING, XRANGE, XREVRANGE, and XREAD can now be issued to replicas.
mp911de added a commit that referenced this issue Apr 23, 2020
@mp911de
Polishing #1271
4375f2e 
Forward-port of GEO read-only commands.
@mp911de
Copy link
Collaborator

mp911de commented Apr 23, 2020

That's fixed now.

@mp911de mp911de closed this as completed Apr 23, 2020
@mp911de mp911de changed the title Stream commands are not considered for ReadOnly routing. Stream commands are not considered for ReadOnly routing Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug A general bug
Projects
None yet
Milestone
5.3.0
Development

No branches or pull requests
2 participants
@mp911de @redviper