Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce visibility of fields in AbstractRedisClient #1241

Closed
mp911de opened this issue Mar 13, 2020 · 0 comments
Closed

Reduce visibility of fields in AbstractRedisClient #1241

mp911de opened this issue Mar 13, 2020 · 0 comments
Labels
type: breaking Breaking change type: task A general task
Milestone
6.0 M1

Comments

@mp911de
Copy link
Collaborator

mp911de commented Mar 13, 2020

Several fields (such as timer, eventLoopGroups) are protected. There's either no need for making them accessible to subclasses or their values can be retrieved by using API. We should reduce their visibility to improve maintainability.
@mp911de mp911de added this to the 6.0 M1 milestone Mar 13, 2020
@mp911de mp911de added type: breaking Breaking change type: task A general task labels Mar 13, 2020
mp911de added a commit that referenced this issue Mar 13, 2020
@mp911de
Reduce visibility of fields in AbstractRedisClient #1241
87dc833 
We now have better encapsulation in AbstractRedisClient. Subclasses use proper accessors and field access is greatly reduced.
@mp911de mp911de closed this as completed Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: breaking Breaking change type: task A general task
Projects
None yet
Milestone
6.0 M1
Development

No branches or pull requests
1 participant
@mp911de