Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support JUSTID flag of XCLAIM command #1233

Closed
christophstrobl opened this issue Feb 20, 2020 · 1 comment
Closed

Support JUSTID flag of XCLAIM command #1233

christophstrobl opened this issue Feb 20, 2020 · 1 comment
Labels
type: feature A new feature
Milestone

Comments

@christophstrobl
Copy link
Contributor

Feature Request

The JUSTID flags allows to obtain the message id from the PEL without increasing the retry counter.

Is your feature request related to a problem? Please describe

Cannot use XCLAIM with JUSTID.

Describe the solution you'd like

RedisFuture<List<String>> xClaimJustId(K key, Consumer<K> consumer, XClaimArgs args, String... messageIds);

Flux<String> xClaimJustId(K key, Consumer<K> consumer, XClaimArgs args, String... messageIds);

Describe alternatives you've considered

Add justid to XClaimArgs and allow to use it with the existing methods so that it returns StreamMessage with an empty body.

@christophstrobl christophstrobl added the type: feature A new feature label Feb 20, 2020
@mp911de mp911de changed the title Support JUSTID flag of XCLAIM command. Support JUSTID flag of XCLAIM command Feb 21, 2020
@mp911de mp911de added this to the 5.3.0 milestone Feb 21, 2020
mp911de added a commit that referenced this issue Feb 21, 2020
We now support XClaimArgs.justid() that requests just the message id without returning the body.
mp911de added a commit that referenced this issue Feb 21, 2020
We now support XClaimArgs.justid() that requests just the message id without returning the body.
@mp911de
Copy link
Collaborator

mp911de commented Feb 21, 2020

That's fixed now. Calling XCLAIM with JUSTID returns StreamMessage objects whose body is null

@mp911de mp911de closed this as completed Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature A new feature
Projects
None yet
Development

No branches or pull requests

2 participants