Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop the HashedWheelTimer before shutting down EventLoopGroups #123

Closed
mp911de opened this issue Aug 26, 2015 · 0 comments
Closed

Stop the HashedWheelTimer before shutting down EventLoopGroups #123

mp911de opened this issue Aug 26, 2015 · 0 comments
Milestone
Lettuce 3.3

Comments

@mp911de
Copy link
Collaborator

mp911de commented Aug 26, 2015

The timer should be stopped before shutting down the EventLoopGroups to enforce no active timer jobs. Exceptions occur in a case of a concurrent shutdown while timer tasks are executed because the event loop is not active anymore, but the timer tries to trigger jobs.
@mp911de mp911de added this to the Lettuce 3.3 milestone Aug 26, 2015
mp911de referenced this issue in ratpack/ratpack Aug 26, 2015
@ldaley
Prevent redis client from spewing messages on shutdown.
68012b1
mp911de added a commit that referenced this issue Aug 26, 2015
@mp911de
Stop the HashedWheelTimer before shutting down EventLoopGroups #123
e5817a4 
Motivation: Active timer tasks can request interaction with a EventLoopGroup that is signalled for shutdown. Tasks in that state are likely to fail and cause exceptions which are logged.

Result: The timer is stopped before the EventLoopGroups are shut down so there are no more active timer tasks when the EventLoops are stopped
mp911de added a commit that referenced this issue Aug 26, 2015
@mp911de
Stop the HashedWheelTimer before shutting down EventLoopGroups #123
e133581 
Motivation: Active timer tasks can request interaction with a EventLoopGroup that is signalled for shutdown. Tasks in that state are likely to fail and cause exceptions which are logged.

Result: The timer is stopped before the EventLoopGroups are shut down so there are no more active timer tasks when the EventLoops are stopped
mp911de added a commit that referenced this issue Aug 26, 2015
@mp911de
Stop the HashedWheelTimer before shutting down EventLoopGroups #123
da60f15 
Motivation: Active timer tasks can request interaction with a EventLoopGroup that is signalled for shutdown. Tasks in that state are likely to fail and cause exceptions which are logged.

Result: The timer is stopped before the EventLoopGroups are shut down so there are no more active timer tasks when the EventLoops are stopped
@mp911de mp911de closed this as completed Aug 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Lettuce 3.3
Development

No branches or pull requests
1 participant
@mp911de