Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning log if MasterReplica(…, Iterable<RedisURI>) contains multiple Sentinel URIs #1165

Closed
mp911de opened this issue Oct 30, 2019 · 0 comments
Closed

Add warning log if MasterReplica(…, Iterable<RedisURI>) contains multiple Sentinel URIs #1165

mp911de opened this issue Oct 30, 2019 · 0 comments
Labels
type: task A general task
Milestone
5.2.1

Comments

@mp911de
Copy link
Collaborator

mp911de commented Oct 30, 2019

Calling MasterReplica accepting a Iterable<RedisURI> considers only the first RedisURI if the first URI is a Redis Sentinel configuration. The remaining elements are dropped silently. #1144 shows a possible misconfiguration and that the expectations to the invoked functionality aren't met. We should issue a warning log if encountering such an arrangement to aid troubleshooting.
@mp911de mp911de added the type: task A general task label Oct 30, 2019
@mp911de mp911de added this to the 5.2.1 milestone Oct 30, 2019
mp911de added a commit that referenced this issue Oct 30, 2019
@mp911de
Add warning log if MasterReplica(…, Iterable<RedisURI>) contains mult…
0eac6c1 
…iple Sentinel URIs #1165
mp911de added a commit that referenced this issue Oct 30, 2019
@mp911de
Add warning log if MasterReplica(…, Iterable<RedisURI>) contains mult…
03c7740 
…iple Sentinel URIs #1165
@mp911de mp911de closed this as completed Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: task A general task
Projects
None yet
Milestone
5.2.1
Development

No branches or pull requests
1 participant
@mp911de