Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass Allocator as RedisStateMachine constructor argument #1053

Closed
mp911de opened this issue Jun 7, 2019 · 1 comment
Closed

Pass Allocator as RedisStateMachine constructor argument #1053

mp911de opened this issue Jun 7, 2019 · 1 comment
Milestone

Comments

@mp911de
Copy link
Collaborator

mp911de commented Jun 7, 2019

No description provided.

@mp911de mp911de changed the title Pass responseElementBuffer as RedisStateMachine constructor argument Pass Allocator as RedisStateMachine constructor argument Nov 8, 2019
mp911de added a commit that referenced this issue Nov 9, 2019
Use provided allocator instead of using a static reference to PooledByteBufAllocator.DEFAULT.
@mp911de mp911de closed this as completed Nov 9, 2019
@mp911de mp911de added this to the 6.0 M1 milestone Nov 9, 2019
@anti-geek
Copy link

@mp911de Hello sir, was this change originally for a potential memory leak in the RedisStateMachine buffer? We are using the old version with a static allocator. Recently, we got a leak report (as follows), and we wonder if this pull request will fix this problem.

LEAK: ByteBuf.release() was not called before it's garbage-collected. See http://netty.io/wiki/reference-counted-objects.html for more information.
Recent access records:
Created at:
io.netty.buffer.PooledByteBufAllocator.newDirectBuffer(PooledByteBufAllocator.java:331)
io.netty.buffer.AbstractByteBufAllocator.directBuffer(AbstractByteBufAllocator.java:185)
io.netty.buffer.AbstractByteBufAllocator.directBuffer(AbstractByteBufAllocator.java:176)
io.lettuce.core.protocol.RedisStateMachine.(RedisStateMachine.java:58)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants