Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve mutators for ClientOptions, ClusterClientOptions, and ClientResources #1003

Closed
mp911de opened this issue Mar 20, 2019 · 1 comment
Closed

Improve mutators for ClientOptions, ClusterClientOptions, and ClientResources #1003

mp911de opened this issue Mar 20, 2019 · 1 comment
Labels
type: bug A general bug type: feature A new feature
Milestone
5.1.6

Comments

@mp911de
Copy link
Collaborator

mp911de commented Mar 20, 2019

We should provide an ability to mutate ClientOptions, ClusterClientOptions, and ClientResources objects to easily enhance options and to create ClusterClientOptions from ClientOptions.

See als https://jira.spring.io/browse/DATAREDIS-949 and spring-projects/spring-boot#16271.
@mp911de mp911de added the type: feature A new feature label Mar 20, 2019
@mp911de mp911de modified the milestones: 5.2.0, 5.1.6 Mar 20, 2019
@mp911de mp911de changed the title Add mutator methods to ClientOptions, ClusterClientOptions, and ClientResources Improve mutators for ClientOptions, ClusterClientOptions, and ClientResources Mar 21, 2019
@mp911de
Copy link
Collaborator Author

mp911de commented Mar 21, 2019

We already have mutators but they return the same underlying builder. If mutations and creations happen independently from each other (e.g. create ClientOptions 1, mutate, create ClientOptions 2, mutate from ClientOptions 1, create ClientOptions 3), then ClientOptions 3 contains also mutations from ClientOptions 2.

@mp911de mp911de added the type: bug A general bug label Mar 21, 2019
mp911de added a commit that referenced this issue Mar 21, 2019
@mp911de
Improve mutators for ClientOptions, ClusterClientOptions, and ClientR…
3381ecd 
…esources #1003

Mutators return decoupled builder instances and do not retain builder state across multiple created instances. Multiple creations do not longer affect each other.

ClientResources also now retains the shared object state across mutations if shared resources (timer, EventLoops) are not altered in the mutation builder.
mp911de added a commit that referenced this issue Mar 21, 2019
@mp911de
Improve mutators for ClientOptions, ClusterClientOptions, and ClientR…
060f1ba 
…esources #1003

Mutators return decoupled builder instances and do not retain builder state across multiple created instances. Multiple creations do not longer affect each other.

ClientResources also now retains the shared object state across mutations if shared resources (timer, EventLoops) are not altered in the mutation builder.
@mp911de mp911de closed this as completed Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug A general bug type: feature A new feature
Projects
None yet
Milestone
5.1.6
Development

No branches or pull requests
1 participant
@mp911de