Un-deprecate ClientOptions.pingBeforeActivateConnection #1208

pingBeforeActivateConnection turns out to be useful when using RESP2 in cases where the connection authentication should be delayed. Another case is when the PING should be used as auth PING to test whether a reconnect was successful. Related ticket: #1201.
redis · Jan 31, 2020 · e18609f · e18609f
1 parent 4af2ba7
commit e18609f
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 7 deletions.
diff --git a/src/main/java/io/lettuce/core/ClientOptions.java b/src/main/java/io/lettuce/core/ClientOptions.java
@@ -135,10 +135,7 @@ protected Builder() {
          *
          * @param pingBeforeActivateConnection true/false
          * @return {@code this}
-         * @deprecated since 5.2. PING during connection handshake becomes mandatory with RESP3. This method will be removed
-         *             with Lettuce 6.
          */
-        @Deprecated
         public Builder pingBeforeActivateConnection(boolean pingBeforeActivateConnection) {
             this.pingBeforeActivateConnection = pingBeforeActivateConnection;
             return this;
@@ -328,10 +325,7 @@ public ClientOptions.Builder mutate() {
      * activated and enabled for use. If the check fails, the connect/reconnect is treated as failure.
      *
      * @return {@literal true} if {@literal PING} barrier is enabled.
-     * @deprecated since 5.2. PING during connection handshake becomes mandatory with RESP3. This method will be removed with
-     *             Lettuce 6.
      */
-    @Deprecated
     public boolean isPingBeforeActivateConnection() {
         return pingBeforeActivateConnection;
     }

diff --git a/src/main/java/io/lettuce/core/cluster/ClusterClientOptions.java b/src/main/java/io/lettuce/core/cluster/ClusterClientOptions.java
@@ -177,7 +177,6 @@ public Builder topologyRefreshOptions(ClusterTopologyRefreshOptions topologyRefr
         }
 
         @Override
-        @Deprecated
         public Builder pingBeforeActivateConnection(boolean pingBeforeActivateConnection) {
             super.pingBeforeActivateConnection(pingBeforeActivateConnection);
             return this;