Avoid long overflow in RedisSubscription.potentiallyReadMore() #2383

Instead of incrementing the demand plus one, we now deduct one from the available data size (which is an int).
redis · Apr 17, 2023 · b3f83e6 · b3f83e6
1 parent 94558a7
commit b3f83e6
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/main/java/io/lettuce/core/RedisPublisher.java b/src/main/java/io/lettuce/core/RedisPublisher.java
@@ -408,7 +408,11 @@ void checkOnDataAvailable() {
 
         void potentiallyReadMore() {
 
-            if ((getDemand() + 1) > data.size()) {
+            /*
+             * getDemand() maybe is Long.MAX_VALUE，because MonoNext.NextSubscriber#request(long n) inner use the Long.MAX_VALUE,
+             * so maybe "getDemand() + 1" will be overflow，we use "getDemand() > data.size() - 1" replace the "(getDemand() + 1) > data.size()"
+             */
+            if (getDemand() > data.size() - 1) {
                 state().readData(this);
             }
         }