Do not cache InetSocketAddress/SocketAddress in RedisURI #144

The SocketAddress obtained by getResolvedAddress is no longer cached. This is to allow dynamic DNS updates at the time of establishing a connection. This change introduces the possibility to change the Redis connection point details because the connection point details are obtained directly from the RedisURI argument.

RELEASE-NOTES.md

@@ -11,6 +11,7 @@ Enhancements
 
 Fixes
 -----
+* Do not cache InetSocketAddress/SocketAddress in RedisURI #144
 
 Other
 ------

src/main/java/com/lambdaworks/redis/RedisURI.java

@@ -80,7 +80,6 @@ public class RedisURI implements Serializable, ConnectionPoint {
     private long timeout = 60;
     private TimeUnit unit = TimeUnit.SECONDS;
     private final List<RedisURI> sentinels = new ArrayList<RedisURI>();
-    private transient SocketAddress resolvedAddress;
 
     /**
      * Default empty constructor.
@@ -339,22 +338,11 @@ public List<RedisURI> getSentinels() {
      * @return the resolved {@link SocketAddress} based either on host/port or the socket.
      */
     public SocketAddress getResolvedAddress() {
-        if (resolvedAddress == null) {
-            resolveAddress();
-        }
-
-        return resolvedAddress;
-    }
-
-    /**
-     * Resolve the address.
-     */
-    private void resolveAddress() {
         if (getSocket() != null) {
-            resolvedAddress = EpollProvider.newSocketAddress(getSocket());
-        } else {
-            resolvedAddress = new InetSocketAddress(host, port);
+            return EpollProvider.newSocketAddress(getSocket());
         }
+
+        return new InetSocketAddress(host, port);
     }
 
     @Override

src/test/java/com/lambdaworks/redis/ClientTest.java

@@ -189,7 +189,6 @@ public void pingBeforeConnectFailOnReconnect() throws Exception {
             assertThat(connectionWatchdog.isReconnectSuspended()).isFalse();
 
             redisUri.setPort(TestSettings.nonexistentPort());
-            ReflectionTestUtils.setField(redisUri, "resolvedAddress", null);
 
             connection.quit();
             Wait.untilTrue(() -> connectionWatchdog.isReconnectSuspended()).waitOrTimeout();
@@ -248,7 +247,6 @@ public void cancelCommandsOnReconnectFailure() throws Exception {
 
             connectionWatchdog.setReconnectSuspended(true);
             redisUri.setPort(TestSettings.nonexistentPort());
-            ReflectionTestUtils.setField(redisUri, "resolvedAddress", null);
 
             connection.quit();
             Wait.untilTrue(() -> !connection.isOpen()).waitOrTimeout();