Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extensive unit tests for PipeliningBase #3778

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Extensive unit tests for PipeliningBase #3778

merged 2 commits into from
Mar 19, 2024

Commits on Mar 18, 2024

  1. Extensive unit tests for PipeliningBase 

    Add extensive unit tests for the PipeliningBase abstract class. Since
this class holds a lot of functionality for its subclasses, it makes
sense to test it in isolation. And since the functionality is very
repetitive, it makes sense to use mocking. Basically this abstract class
just shuffles commands around from a CommandObjects to its subclasses,
and this can be covered very well with mocked tests.
    @gerzse
    gerzse committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    5601920 View commit details
    Browse the repository at this point in the history

  2. Fix flaky test 

    A slow log test seems to sometimes get a duration of zero for an
operation. Cover this case too in the assertion.
    @gerzse
    gerzse committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    93ab19e View commit details
    Browse the repository at this point in the history