Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate builder factory for each module #3277

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

sazzad16
Copy link
Collaborator

@sazzad16 sazzad16 commented Jan 11, 2023

This is polishing #3249 and more.

@sazzad16 sazzad16 added breakingchange Pull request that has breaking changes. Must include the breaking behavior in release notes. maintenance labels Jan 11, 2023
@sazzad16 sazzad16 added this to the 4.4.0 milestone Jan 11, 2023
@sazzad16 sazzad16 requested a review from chayim January 11, 2023 13:26
@codecov-commenter
Copy link

Codecov Report

Base: 66.94% // Head: 66.92% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (1bb5ccf) compared to base (bc1d02a).
Patch coverage: 81.42% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3277      +/-   ##
============================================
- Coverage     66.94%   66.92%   -0.03%     
- Complexity     4635     4639       +4     
============================================
  Files           256      258       +2     
  Lines         15014    15020       +6     
  Branches        937      937              
============================================
+ Hits          10051    10052       +1     
- Misses         4560     4566       +6     
+ Partials        403      402       -1     
Impacted Files Coverage Δ
.../main/java/redis/clients/jedis/BuilderFactory.java 74.58% <ø> (-2.21%) ⬇️
...a/redis/clients/jedis/json/JsonBuilderFactory.java 58.82% <58.82%> (ø)
...nts/jedis/timeseries/TimeSeriesBuilderFactory.java 87.50% <87.50%> (ø)
...dis/clients/jedis/search/SearchBuilderFactory.java 88.50% <88.50%> (ø)
.../main/java/redis/clients/jedis/CommandObjects.java 85.16% <100.00%> (+0.03%) ⬆️
...nts/jedis/providers/ClusterConnectionProvider.java 75.00% <0.00%> (-3.58%) ⬇️
src/main/java/redis/clients/jedis/Protocol.java 90.62% <0.00%> (-1.25%) ⬇️
...ava/redis/clients/jedis/JedisClusterInfoCache.java 75.62% <0.00%> (+3.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sazzad16 sazzad16 merged commit c4506e4 into redis:master Jan 24, 2023
@sazzad16 sazzad16 deleted the builder-factory branch January 24, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breakingchange Pull request that has breaking changes. Must include the breaking behavior in release notes. maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants