Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Sentinel constructor #2574

Merged
merged 3 commits into from
Jul 14, 2021
Merged

Fix Sentinel constructor #2574

merged 3 commits into from
Jul 14, 2021

Conversation

sazzad16
Copy link
Collaborator

Fixes #2572

@sazzad16 sazzad16 added this to the 3.6.2 milestone Jun 30, 2021
@gkorland
Copy link
Contributor

gkorland commented Jul 1, 2021

@sazzad16 what about test?

@sazzad16
Copy link
Collaborator Author

sazzad16 commented Jul 1, 2021

@gkorland We'll need a whole sentinel cluster where sentinel nodes would be using ACL. So I thought to skip for now.

@sazzad16 sazzad16 merged commit 2dd403a into redis:3 Jul 14, 2021
@sazzad16 sazzad16 deleted the sentinel-init branch July 14, 2021 05:49
sazzad16 added a commit that referenced this pull request Jul 14, 2021
@sazzad16
Fix Sentinel constructor (#2574)
ac85198
@sazzad16 sazzad16 mentioned this pull request Jul 14, 2021
Closed
@chayim chayim mentioned this pull request Jun 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dengliming dengliming dengliming approved these changes

@mina-asham mina-asham mina-asham approved these changes

@gkorland gkorland Awaiting requested review from gkorland

@yangbodong22011 yangbodong22011 Awaiting requested review from yangbodong22011

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.6.2
Development

Successfully merging this pull request may close these issues.
4 participants
@sazzad16 @gkorland @mina-asham @dengliming