Implements BITFIELD_RO command

src/main/java/redis/clients/jedis/BinaryClient.java

@@ -1320,6 +1320,10 @@ public void bitfield(final byte[] key, final byte[]... value) {
     sendCommand(BITFIELD, joinParameters(key, value));
   }
 
+  public void bitfieldReadonly(final byte[] key, final byte[]... arguments) {
+    sendCommand(BITFIELD_RO, joinParameters(key, arguments));
+  }
+
   public void hstrlen(final byte[] key, final byte[] field) {
     sendCommand(HSTRLEN, key, field);
   }

src/main/java/redis/clients/jedis/BinaryJedis.java

@@ -4059,6 +4059,13 @@ public List<Long> bitfield(final byte[] key, final byte[]... arguments) {
     return client.getIntegerMultiBulkReply();
   }
 
+  @Override
+  public List<Long> bitfieldReadonly(byte[] key, final byte[]... arguments) {
+    checkIsInMultiOrPipeline();
+    client.bitfieldReadonly(key, arguments);
+    return client.getIntegerMultiBulkReply();
+  }
+
   @Override
   public Long hstrlen(final byte[] key, final byte[] field) {
     checkIsInMultiOrPipeline();

src/main/java/redis/clients/jedis/BinaryJedisCluster.java

@@ -2084,6 +2084,16 @@ public List<Long> execute(Jedis connection) {
     }.runBinary(key);
   }
 
+  @Override
+  public List<Long> bitfieldReadonly(final byte[] key, final byte[]... arguments) {
+    return new JedisClusterCommand<List<Long>>(connectionHandler, maxAttempts) {
+      @Override
+      public List<Long> execute(Jedis connection) {
+        return connection.bitfieldReadonly(key, arguments);
+      }
+    }.runBinary(key);
+  }
+
   @Override
   public Long hstrlen(final byte[] key, final byte[] field) {
     return new JedisClusterCommand<Long>(connectionHandler, maxAttempts) {

src/main/java/redis/clients/jedis/BinaryShardedJedis.java

@@ -977,6 +977,12 @@ public List<Long> bitfield(final byte[] key, final byte[]... arguments) {
     return j.bitfield(key, arguments);
  }
 
+  @Override
+  public List<Long> bitfieldReadonly(byte[] key, final byte[]... arguments) {
+    Jedis j = getShard(key);
+    return j.bitfieldReadonly(key, arguments);
+  }
+
   @Override
   public Long hstrlen(final byte[] key, final byte[] field) {
     Jedis j = getShard(key);

src/main/java/redis/clients/jedis/Client.java

@@ -1193,6 +1193,11 @@ public void bitfield(final String key, final String... arguments) {
     bitfield(SafeEncoder.encode(key), SafeEncoder.encodeMany(arguments));
   }
 
+  @Override
+  public void bitfieldReadonly(String key, final String... arguments) {
+    bitfieldReadonly(SafeEncoder.encode(key), SafeEncoder.encodeMany(arguments));
+  }
+
   @Override
   public void hstrlen(final String key, final String field) {
     hstrlen(SafeEncoder.encode(key), SafeEncoder.encode(field));

src/main/java/redis/clients/jedis/Jedis.java

@@ -3746,6 +3746,13 @@ public List<Long> bitfield(final String key, final String...arguments) {
     return client.getIntegerMultiBulkReply();
   }
 
+  @Override
+  public List<Long> bitfieldReadonly(final String key, final String... arguments) {
+    checkIsInMultiOrPipeline();
+    client.bitfieldReadonly(key, arguments);
+    return client.getIntegerMultiBulkReply();
+  }
+
   @Override
   public Long hstrlen(final String key, final String field) {
     checkIsInMultiOrPipeline();

src/main/java/redis/clients/jedis/JedisCluster.java

@@ -2119,6 +2119,16 @@ public List<Long> execute(Jedis connection) {
     }.run(key);
   }
 
+  @Override
+  public List<Long> bitfieldReadonly(final String key, final String... arguments) {
+    return new JedisClusterCommand<List<Long>>(connectionHandler, maxAttempts) {
+      @Override
+      public List<Long> execute(Jedis connection) {
+        return connection.bitfieldReadonly(key, arguments);
+      }
+    }.run(key);
+  }
+
   @Override
   public Long hstrlen(final String key, final String field) {
     return new JedisClusterCommand<Long>(connectionHandler, maxAttempts) {

src/main/java/redis/clients/jedis/PipelineBase.java

@@ -1826,6 +1826,18 @@ public Response<List<Long>> bitfield(final byte[] key, final byte[]... elements)
     return getResponse(BuilderFactory.LONG_LIST);
   }
 
+  @Override
+  public Response<List<Long>> bitfieldReadonly(byte[] key, final byte[]... arguments) {
+    getClient(key).bitfieldReadonly(key, arguments);
+    return getResponse(BuilderFactory.LONG_LIST);
+  }
+
+  @Override
+  public Response<List<Long>> bitfieldReadonly(String key, final String... arguments) {
+    getClient(key).bitfieldReadonly(key, arguments);
+    return getResponse(BuilderFactory.LONG_LIST);
+  }
+
   @Override
   public Response<Long> hstrlen(final String key, final String field) {
     getClient(key).hstrlen(key, field);

src/main/java/redis/clients/jedis/Protocol.java

@@ -260,7 +260,7 @@ public static enum Command implements ProtocolCommand {
     PFADD, PFCOUNT, PFMERGE, READONLY, GEOADD, GEODIST, GEOHASH, GEOPOS, GEORADIUS, GEORADIUS_RO,
     GEORADIUSBYMEMBER, GEORADIUSBYMEMBER_RO, MODULE, BITFIELD, HSTRLEN, TOUCH, SWAPDB, MEMORY,
     XADD, XLEN, XDEL, XTRIM, XRANGE, XREVRANGE, XREAD, XACK, XGROUP, XREADGROUP, XPENDING, XCLAIM,
-    ACL, XINFO;
+    ACL, XINFO, BITFIELD_RO;
 
     private final byte[] raw;
 

src/main/java/redis/clients/jedis/ShardedJedis.java

@@ -986,6 +986,12 @@ public List<Long> bitfield(final String key, final String... arguments) {
     return j.bitfield(key, arguments);
   }
 
+  @Override
+  public List<Long> bitfieldReadonly(String key, final String... arguments) {
+    Jedis j = getShard(key);
+    return j.bitfieldReadonly(key, arguments);
+  }
+
   @Override
   public Long hstrlen(final String key, final String field) {
     Jedis j = getShard(key);

src/main/java/redis/clients/jedis/commands/BinaryJedisClusterCommands.java

@@ -321,6 +321,8 @@ List<GeoRadiusResponse> georadiusByMemberReadonly(byte[] key, byte[] member, dou
    * @return 
    */
   List<Long> bitfield(byte[] key, byte[]... arguments);
+
+  List<Long> bitfieldReadonly(byte[] key, byte[]... arguments);
 
   /**
    * Used for HSTRLEN Redis command

src/main/java/redis/clients/jedis/commands/BinaryJedisCommands.java

@@ -331,6 +331,8 @@ List<GeoRadiusResponse> georadiusByMemberReadonly(byte[] key, byte[] member, dou
    * @return 
    */
   List<Long> bitfield(byte[] key, byte[]... arguments);
+
+  List<Long> bitfieldReadonly(byte[] key, byte[]... arguments);
 
   /**
    * Used for HSTRLEN Redis command

src/main/java/redis/clients/jedis/commands/BinaryRedisPipeline.java

@@ -311,6 +311,8 @@ Response<List<GeoRadiusResponse>> georadiusByMemberReadonly(byte[] key, byte[] m
 
   Response<List<Long>> bitfield(byte[] key, byte[]... elements);
 
+  Response<List<Long>> bitfieldReadonly(byte[] key, byte[]... elements);
+
   Response<Long> hstrlen(byte[] key, byte[] field);
 
   Response<byte[]> xadd(byte[] key, byte[] id, Map<byte[], byte[]> hash);

src/main/java/redis/clients/jedis/commands/Commands.java

@@ -347,6 +347,8 @@ void zrevrangeByScoreWithScores(String key, String max, String min,
    */
   void bitfield(String key, String... arguments);
 
+  void bitfieldReadonly(String key, String... arguments);
+
   /**
    * Used for HSTRLEN Redis command
    * @param key

src/main/java/redis/clients/jedis/commands/JedisClusterCommands.java

@@ -319,6 +319,8 @@ List<GeoRadiusResponse> georadiusByMemberReadonly(String key, String member, dou
    * @return 
    */
   List<Long> bitfield(String key, String...arguments);
+
+  List<Long> bitfieldReadonly(String key, String...arguments);
 
   /**
    * Used for HSTRLEN Redis command

src/main/java/redis/clients/jedis/commands/JedisCommands.java

@@ -345,6 +345,8 @@ List<GeoRadiusResponse> georadiusByMemberReadonly(String key, String member, dou
    */
   List<Long> bitfield(String key, String...arguments);
 
+  List<Long> bitfieldReadonly(String key, String...arguments);
+
   /**
    * Used for HSTRLEN Redis command
    * @param key 

src/main/java/redis/clients/jedis/commands/RedisPipeline.java

@@ -259,6 +259,8 @@ Response<Set<String>> zrevrangeByLex(String key, String max, String min,
   Response<Long> pfcount(String key);
 
   Response<List<Long>> bitfield(String key, String... arguments);
+
+  Response<List<Long>> bitfieldReadonly(String key, String... arguments);
 
   Response<Long> hstrlen(String key, String field);
 

src/test/java/redis/clients/jedis/tests/commands/BitCommandsTest.java

@@ -3,12 +3,14 @@
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertFalse;
 import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.fail;
 
 import org.junit.Test;
 
 import redis.clients.jedis.BitOP;
 import redis.clients.jedis.BitPosParams;
 import redis.clients.jedis.Protocol;
+import redis.clients.jedis.exceptions.JedisDataException;
 import redis.clients.jedis.util.SafeEncoder;
 
 import java.util.List;
@@ -197,6 +199,21 @@ public void testBitfield() {
     assertEquals(0L, responses.get(1).longValue());
   }
 
+  @Test
+  public void testBitfieldReadonly() {
+    List<Long> responses = jedis.bitfield("mykey", "INCRBY","i5","100","1", "GET", "u4", "0");
+    assertEquals(1L, responses.get(0).longValue());
+    assertEquals(0L, responses.get(1).longValue());
+
+    List<Long> responses2 = jedis.bitfieldReadonly("mykey", "GET", "i5", "100");
+    assertEquals(1L, responses2.get(0).longValue());
+
+    try {
+      jedis.bitfieldReadonly("mykey", "INCRBY","i5","100","1", "GET", "u4", "0");
+      fail("Readonly command shouldn't allow INCRBY");
+    }catch(JedisDataException e) {}
+  }
+
   @Test
   public void testBinaryBitfield() {
     List<Long> responses = jedis.bitfield(SafeEncoder.encode("mykey"), SafeEncoder.encode("INCRBY"),
@@ -207,4 +224,15 @@ public void testBinaryBitfield() {
     assertEquals(0L, responses.get(1).longValue());
   }
 
+  @Test
+  public void testBinaryBitfieldReadonly() {
+    List<Long> responses = jedis.bitfield("mykey", "INCRBY","i5","100","1", "GET", "u4", "0");
+    assertEquals(1L, responses.get(0).longValue());
+    assertEquals(0L, responses.get(1).longValue());
+
+    List<Long> responses2 = jedis.bitfieldReadonly(SafeEncoder.encode("mykey"), SafeEncoder.encode("GET"),
+        SafeEncoder.encode("i5"), SafeEncoder.encode("100"));
+    assertEquals(1L, responses2.get(0).longValue());
+  }
+
 }