-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for Redis 6 ACL - Issue #2035 #2077
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM. Please see the comments.
src/test/java/redis/clients/jedis/tests/JedisSentinelPoolTest.java
Outdated
Show resolved
Hide resolved
src/main/java/redis/clients/jedis/exceptions/JedisAuthenticationException.java
Outdated
Show resolved
Hide resolved
…hods to Binary Client/Jedis classes - see first PR comment
…CL methods as suggested by @sazzad16
@gkorland |
Hi, @tgrall please, do you know when this PR can be merged and when new Jedis with the feature will be released? Thanks. |
@tgrall can you please resolve the conflicts? |
I will work on it during the hollidays |
@gkorland I have solved the conflict and merge master to the PR branch |
WDYT? |
Hi @gkorland, please, could you add your review/comment to be able to move forward? PR is opened quite long. I would really appreciate to have available the feature soon. Thank you |
@tgrall notice the use case of URI connection is not handled |
Hmm, I thought I started here.
I guess I have lost it somewhere.
let me work on it and add it this week.
…On Sun 2 Feb 2020 at 17:08, Guy Korland ***@***.***> wrote:
@tgrall <https://github.com/tgrall> notice the use case of URI connection
is not handled
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2077>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEEEQQH26XMTOVLGYCQMVLRA3VXJANCNFSM4JAGJYWQ>
.
|
@gkorland I have added the support for URL auth. |
I think Redis 6 RC is available. When the new Jedis with ACL support will be available? |
Is it still relevant? Do you mean the names of the tests? |
Yes and yes. But I'm merging it now and will try to change it myself. |
@tgrall Thanks for the great contribution! |
This pull request adds support so ACL to Jedis (issue #2035), the following commands have been added:
jedis.aclList()
)jedis.aclUsers()
)jedis.setUser(name, option1, options2, ...)
)jedis.aclGetUser(name)
)jedis.aclDelUser(name)
)jedis.aclCat()
)jedis.aclCat(cat)
)jedis.aclGenPass()
)jedis.aclWhoAmI()
)Not Implemented: ACL LOAD / ACL SAVE
Tested have been written to be ignored when the redis_version is smaller than 6.
I have duplicated the tests
JedisPoolTest
,JedisSentinelPoolTest
,JedisTest
,ShardedJedisPoolTest
,SSLJedisTest
, adding WithCompleteCredentials in the classname.Also, I think we should, if people are using Jedis to create user and set ACL, create a small DSL/or set of Classes that would help the developers to use the
setUser
method.