-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve javadocs #978
Comments
Just ran into #976 as well and finding the docs lacking. |
@kag0 we're working on some important core features of Jedis at this moment and we're only two active collaborators. Any help would be much appreciated 😄 |
I thought about Javadoc a little. As Marcos said, we're only two active collaborators. Btw, we can move javadoc from implementations to interfaces, and use @inheritdoc tag to reduce amount of duplicated comments. |
@HeartSaVioR moving Javadocs to interfaces seems the right way to go. I don't have time to do that kind of work at this moment, hopefully some new collaborator would help :) |
OK. I also think we may just replace the explanations for the command to link to Redis doc, since it is actively maintained with many contributors. |
If we replace javadocs with redis links then users without internet connection won't be able to see the docs (which is kind of sad). Redis docs are stored in a JSON format in the redis page repo. Maybe we can annotate the javadocs in some way which allows us to run a simple program which takes the commands description form the redis json doc and replaces it into Jedis. I'm not sure about this exactly but I agree with you that maintaining the documentation is quite messy as we don't have the enough collaborators to do it ATM. |
javadocs support html in the comments, so you could potentially do something there with the redis docs. Wouldn't fix issues like #976 though. |
@kag0 👍 |
@marcosnils will you please create a gh-pages branch (off of master) so I can open a PR into it? |
@kag0 Done. |
The Jedis docs for each command are just a copy paste of Redis docs which doesn't translate well to Java. redis/jedis#978 From some stack overflow googling, we see the right way to use zrank(), and this patch changes the code to comply with that.
The Jedis docs for each command are just a copy paste of Redis docs which doesn't translate well to Java. redis/jedis#978 From some stack overflow googling, we see the right way to use zrank(), and this patch changes the code to comply with that.
This issue is marked stale. It will be closed in 30 days if it is not updated. |
Javadocs are mainly a copy/paste of the redis documentation. We need to change them to represent proper java types and exception handling.
There are also methods which doesn't have any javadoc at all.
The text was updated successfully, but these errors were encountered: