Minor: remove empty sequence checks

redis · Mar 19, 2022 · 4cb4fae · 4cb4fae
1 parent 19585d4
commit 4cb4fae
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 14 deletions.
diff --git a/src/main/java/redis/clients/jedis/UnifiedJedis.java b/src/main/java/redis/clients/jedis/UnifiedJedis.java
@@ -2,7 +2,6 @@
 
 import java.net.URI;
 import java.time.Duration;
-import java.util.Collections;
 import java.util.List;
 import java.util.Map;
 import java.util.Set;
@@ -3923,9 +3922,6 @@ public boolean bfExists(String key, String item) {
 
   @Override
   public List<Boolean> bfMExists(String key, String... items) {
-    if (items.length == 0) {
-      return Collections.emptyList();
-    }
     return executeCommand(commandObjects.bfMExists(key, items));
   }
 
@@ -3981,13 +3977,9 @@ public boolean cfExists(String key, String item) {
 
   @Override
   public List<Boolean> cfMExists(String key, String... items) {
-    if (items.length == 0) {
-      return Collections.emptyList();
-    }
     return executeCommand(commandObjects.cfMExists(key, items));
   }
 
-
   @Override
   public boolean cfDel(String key, String item) {
     return executeCommand(commandObjects.cfDel(key, item));

diff --git a/src/main/java/redis/clients/jedis/bloom/CuckooFilterCommands.java b/src/main/java/redis/clients/jedis/bloom/CuckooFilterCommands.java
@@ -112,7 +112,7 @@ public interface CuckooFilterCommands {
    * {@code CF.MEXISTS {key} {item ...}}
    *
    * @param key   The name of the filter
-   * @param items Items to check for
+   * @param items Items to check for (non empty sequence)
    * @return a list of booleans where false if the item certainly does not exist,
    *         true if the item may exist.
    */

diff --git a/src/test/java/redis/clients/jedis/modules/bloom/BloomTest.java b/src/test/java/redis/clients/jedis/modules/bloom/BloomTest.java
@@ -6,7 +6,6 @@
 import static org.junit.Assert.fail;
 
 import java.util.Arrays;
-import java.util.Collections;
 import java.util.List;
 import java.util.Map;
 import org.junit.AfterClass;
@@ -217,8 +216,8 @@ public void insertExpansion() {
     assertEquals(20, insert.size());
   }
 
-  @Test
+  @Test(expected = JedisDataException.class)
   public void testNoItemMExists() {
-    assertEquals(Collections.emptyList(), client.bfMExists("simpleBloom"));
+    client.bfMExists("simpleBloom");
   }
 }
diff --git a/src/test/java/redis/clients/jedis/modules/bloom/CuckooTest.java b/src/test/java/redis/clients/jedis/modules/bloom/CuckooTest.java
@@ -191,9 +191,9 @@ public void testExistsItemExists() {
     assertEquals(Collections.singletonList(true), client.cfMExists("cuckoo17", "foo"));
   }
 
-  @Test
+  @Test(expected = JedisDataException.class)
   public void testNoItemMExists() {
-    assertEquals(Collections.emptyList(), client.cfMExists("cuckoo17"));
+    client.cfMExists("cuckoo17");
   }
 
   @Test