Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cluster: passing deeply frozen options causes crash #887

Closed
jstewmon opened this issue Jun 8, 2019 · 1 comment
Closed

cluster: passing deeply frozen options causes crash #887

jstewmon opened this issue Jun 8, 2019 · 1 comment
Labels
bug released

Comments

@jstewmon
Copy link
Contributor

jstewmon commented Jun 8, 2019

Passing a deeply frozen options object may result in an uncaught exception, causing a crash. I think this may only apply when natMap is passed. The failure occurs here.

TypeError: Cannot add property readOnly, object is not extensible
    at getInfoFromNode.duplicatedConnection.cluster.utils_1.timeout (/home/node/app/node_modules/ioredis/built/cluster/index.js:601:39)
    at run (/home/node/app/node_modules/ioredis/built/utils/index.js:150:22)
    at tryCatcher (/home/node/app/node_modules/standard-as-callback/built/utils.js:11:23)
    at promise.then (/home/node/app/node_modules/standard-as-callback/built/index.js:19:49)
    at process._tickCallback (internal/process/next_tick.js:68:7)
@luin luin added the bug label Jun 9, 2019
@luin luin closed this as completed in 3bc6165 Jun 11, 2019
ioredis-robot pushed a commit that referenced this issue Jun 11, 2019
@semantic-release-bot
chore(release): 4.10.4 [skip ci]
7e65619 
## [4.10.4](v4.10.3...v4.10.4) (2019-06-11)

### Bug Fixes

* **cluster:** passing frozen natMap option causes crash ([3bc6165](3bc6165)), closes [#887](#887)
@ioredis-robot
Copy link
Collaborator

🎉 This issue has been resolved in version 4.10.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

janus-dev87 added a commit to janus-dev87/ioredis-work that referenced this issue Mar 1, 2024
@janus-dev87
chore(release): 4.10.4 [skip ci]
60de06c 
## [4.10.4](redis/ioredis@v4.10.3...v4.10.4) (2019-06-11)

### Bug Fixes

* **cluster:** passing frozen natMap option causes crash ([3bc6165](redis/ioredis@3bc6165)), closes [#887](redis/ioredis#887)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@luin @jstewmon @ioredis-robot