Remove trailing comma in redisConnectionType enum #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove trailing comma in last value of `redisConnectionType` enum. This causes a compiler warning on Solaris compilers. I'd like to build this on Solaris with `-Werror`. However, due to the trailing comma, I cannot do that. This PR removes the trailing comma, which should prevent it causing compiler warnings on any architecture.
|
Who the hell made trailing commas in enum definitions a warning on Solaris? |
|
Yes, it's an interesting choice. This offers an explanation: http://stackoverflow.com/questions/6372650/trailing-commas-and-c The Solaris compiler used is C++03 (a fully C++11-conformant Solaris compiler currently does not exist sadly). C++03 tries to be backwards compatible with C89, which does not allow trailing commas. C99 does allow trailing commas, and only C++11 has caught up with C99 by also allowing them. As long as we're stuck with C++03-ish compilers for Solaris, trailing commas will be an issue. |
|
Is this good to land? |
|
I guess, yes. |
|
Thanks @badboy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove trailing comma in last value of
redisConnectionTypeenum. This causes a compiler warning on Solaris compilers. I'd like to build this on Solaris with-Werror. However, due to the trailing comma, I cannot do that.This PR removes the trailing comma, which should prevent it causing compiler warnings on any architecture.