Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: should close socket fd when retry connect (tcp) #445

Merged
1 commit merged into from
Jul 9, 2016
Merged

fix: should close socket fd when retry connect (tcp) #445

1 commit merged into from
Jul 9, 2016

Conversation

wwcd
Copy link

@wwcd wwcd commented Jul 7, 2016

No description provided.

@wwcd wwcd changed the title fix: should close socket fd when retry conne (tcp) fix: should close socket fd when retry connect (tcp) Jul 7, 2016
@badboy
Copy link
Contributor

badboy commented Jul 9, 2016

I guess it makes sense. I think there is no proper way to test this reliable though.

@badboy
Copy link
Contributor

badboy commented Jul 9, 2016 

APPLICATION USAGE
       If connect() fails, the state of the socket is unspecified. Conforming applications should close the file descriptor and create a new socket before attempting to reconnect.

Perfect.

@not-A-robot r+

@ghost
Copy link

ghost commented Jul 9, 2016

📌 Commit 64d1ec8 has been approved by badboy

@ghost
Copy link

ghost commented Jul 9, 2016

⚡ Test exempted - status

@ghost ghost merged commit 64d1ec8 into redis:master Jul 9, 2016
ghost pushed a commit that referenced this pull request Jul 9, 2016
Auto merge of #445 - xxvv:master, r=badboy
5f98e1d 
fix: should close socket fd when retry connect (tcp)
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wwcd @badboy