Less surprising behaviour in redisFree() and freeReplyObject() #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make redisFree() and freeReplyObject() less surprising by behaving just like free(). That is, don't crash when passing in NULL.
|
Can you add a test for these as well? I want to make sure this behavior doesn't break after refactoring. |
Test that redisFree() and freeReplyObject() do not crash when NULL is passed in.
|
I've added the tests, but the test conditions are a bit silly. I mean, the return type is void and they either crash or work, so it's the best I could think of without modifying the test framework. |
|
I think that's fine. A crashing test is a failing test ;) Merging the code. Thanks for your contribution. |
pietern
added a commit
that referenced
this pull request
May 29, 2014
Less surprising behaviour in redisFree() and freeReplyObject()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make redisFree() and freeReplyObject() less surprising by behaving just
like free(). That is, don't crash when passing in NULL.