Fixup of PR734: Coverage of hiredis.c #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- double covered by: "Can parse RESP3 doubles" - bool covered via: "Can parse RESP3 bool"
Restructure testcase since redisConnectWithTimeout() and redisConnectUnixWithTimeout() now behaves similar.
Use new testcase info text since the previous seemed copy&pasted. The seeked coverage was the handling of the parent-chaining for a Double object, which the testcase now focus on.
michael-grunder
approved these changes
Oct 14, 2022
|
Merged, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #734 with a couple of fixups for the remaining changes.
The coverage in hiredis.c is increased from
81.5%to84.6%.Closes #734