Update hiredis sds with improvements found in redis

[bjosv]

Update hiredis sds with improvements found in redis for convergence,
like the overflow mentioned in redis/redis#9706

Handpicked from:
redis/redis#4568
redis/redis#9584
redis/redis#8522

[bjosv]

Ouch, it looks like CentOS8 has gone EOL and that we need to do some updates for CI.

[michael-grunder]

I actually ran into the CentOS issue yesterday and even complained about it on Twitter 😄

I believe there is a short-term solution to this. I'll get that up now.

[bjosv]

😀 ahh, I missed that one in my feed.
Yeah, at least they didn't kill it at New Year's Eve when it hit EOL... so they had it prolonged to the Chinese New Year instead 🙄

[michael-grunder]

Thanks for porting these over.

I wonder if we can avoid the asserts on overflow though. Simply return NULL instead so the error is just treated like an OOM for clients of the library.

[bjosv]

I wonder if we can avoid the asserts on overflow though. Simply return NULL instead so the error is just treated like an OOM for clients of the library.

Yes, you are right, much better. This follows how its handled in other places

[bjosv]

Sorry, touchpad gone wild.. updated the PR with the change.

[michael-grunder]

Merged, thanks!