-
Notifications
You must be signed in to change notification settings - Fork 84
N-API Support for hiredis-node #139
base: napi
Are you sure you want to change the base?
Conversation
I'm seeing lots of build failures on Windows (but some successes). Is the plan to work through those or are they expected for the N-API implementation? Happy to merge into the napi branch but again I'm completely unfamiliar with node. |
Hi @michael-grunder, |
OK sounds great. I'll keep an eye on the PR. |
Any updates on this? |
Hi @shirtleton, This is what I obtain executing benchmark on the N-API version:
This is what I obtain using the actual version of the add-on:
I hope to solve all in a reasonable time. |
This PR contains initial work to port hiredis module to new N-API