Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dep compatibility #1171

Closed
wants to merge 3 commits into from
Closed

Conversation

kollektiv
Copy link
Contributor

Fixes: #1148, #1143

Currently if you try to use dep with go-redis v7, dep will place the files in ./vendor/github.com/go-redis/redis, and then error because the imports, github.com/go-redis/redis/v7, are mismatched with file locations. Dep minimal module awareness issue: golang/dep#1962

Go files have been moved to the top-level into the "v7" subdirectory. This makes it possible to use go-redis v7 with the dep dependency manager, and still compatible with go modules. dep places files on disk at "./github.com/go-redis/redis/v7".

The forward.go file is generated using goforward (https://go-review.googlesource.com/c/tools/+/137076/) to add aliases that point to github.com/go-redis/redis to github.com/go-redis/redis/v7. The goforward tool is mentioned in this section https://github.com/golang/go/wiki/Modules#releasing-modules-v2-or-higher

@vmihailenco
Copy link
Collaborator

Sorry, but this is considerable amount of work and demand is not high. I've migrated all projects to go mod and don't regret it - in long term that is the best and simplest thing to do.

@vmihailenco vmihailenco closed this Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can't build the project
2 participants