Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAPI: Consolidate database examples and add Essentials information #1000

Merged
merged 8 commits into from
Dec 20, 2024
Merged

CAPI: Consolidate database examples and add Essentials information #1000

merged 8 commits into from
Dec 20, 2024
+58 −111

Conversation

cmilesb
Copy link
Contributor

@cmilesb cmilesb commented Dec 18, 2024

@cmilesb cmilesb added the rc Redis Cloud docs label Dec 18, 2024
@cmilesb cmilesb requested review from NoamSternRedis and a team December 18, 2024 22:57
@cmilesb cmilesb self-assigned this Dec 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 18, 2024 •
edited
Loading

Staging links:
https://redis.io/docs/staging/DOC-4657/operate/rc/api/
https://redis.io/docs/staging/DOC-4657/operate/rc/api/examples/create-database
https://redis.io/docs/staging/DOC-4657/operate/rc/api/examples/manage-subscriptions

@cmilesb cmilesb changed the base branch from DOC-4656 to main December 18, 2024 23:04
dwdougherty
dwdougherty approved these changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@dwdougherty dwdougherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Language looks mostly okay to me; just two suggestions.

content/operate/rc/api/examples/create-database.md Outdated Show resolved Hide resolved
content/operate/rc/api/examples/create-database.md Outdated Show resolved Hide resolved
@cmilesb cmilesb merged commit 9b13dab into main Dec 20, 2024
5 checks passed
@cmilesb cmilesb deleted the DOC-4657 branch December 20, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwdougherty dwdougherty dwdougherty approved these changes

@NoamSternRedis NoamSternRedis Awaiting requested review from NoamSternRedis

Assignees

@cmilesb cmilesb

Labels
rc Redis Cloud docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmilesb @dwdougherty