Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make no-concurrency mode default #411

Merged

Conversation

supercaracal
Copy link
Member

@supercaracal supercaracal commented Nov 19, 2024

ruby 3.3.6 (2024-11-05 revision 75015d4c1f) [x86_64-linux]
Warming up --------------------------------------
 pipelined: ondemand    72.000 i/100ms
   pipelined: pooled    82.000 i/100ms
     pipelined: none    84.000 i/100ms
    pipelined: envoy    80.000 i/100ms
   pipelined: cproxy    39.000 i/100ms
Calculating -------------------------------------
 pipelined: ondemand    715.452 (± 6.6%) i/s    (1.40 ms/i) -      3.600k in   5.064794s
   pipelined: pooled    830.765 (± 0.7%) i/s    (1.20 ms/i) -      4.182k in   5.034200s
     pipelined: none    846.257 (± 5.8%) i/s    (1.18 ms/i) -      4.284k in   5.084215s
    pipelined: envoy    805.275 (± 7.0%) i/s    (1.24 ms/i) -      4.000k in   5.007049s
   pipelined: cproxy    400.326 (± 5.2%) i/s    (2.50 ms/i) -      2.028k in   5.085483s

Comparison:
     pipelined: none:      846.3 i/s
   pipelined: pooled:      830.8 i/s - same-ish: difference falls within error
    pipelined: envoy:      805.3 i/s - same-ish: difference falls within error
 pipelined: ondemand:      715.5 i/s - 1.18x  slower
   pipelined: cproxy:      400.3 i/s - 2.11x  slower

The thread-initialization cost is too expensive against a standart-scale service.

@supercaracal supercaracal marked this pull request as ready for review November 19, 2024 13:00
@supercaracal supercaracal merged commit 1512a0d into redis-rb:master Nov 19, 2024
33 checks passed
@supercaracal supercaracal deleted the fix-default-concurrency-mode branch November 19, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant