Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add setup_acm_agents role #455

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add setup_acm_agents role #455

wants to merge 1 commit into from
+271 −0

Conversation

betoredhat
Copy link
Contributor

SUMMARY

A role to setup ACM agents that can be used for BM deployments

ISSUE TYPE
  • New or Enhanced Feature
Tests
  • [] TestDallas -
  • [] TestBos2 -

Test-Hint: no-check

@betoredhat betoredhat requested review from a team as code owners October 3, 2024 23:36
@dcibot
Copy link
Collaborator

dcibot commented Oct 3, 2024

from change #455:

  • no check (not a code change)

1 similar comment
@dcibot
Copy link
Collaborator

dcibot commented Oct 3, 2024

from change #455:

  • no check (not a code change)

@betoredhat betoredhat marked this pull request as draft October 3, 2024 23:36
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/ed38f6d1c7d54d37adb4add8d8724365

✔️ dci-rpm-build-el8 SUCCESS in 2m 43s
✔️ dci-rpm-build-el9 SUCCESS in 2m 26s

nsilla
nsilla reviewed Oct 4, 2024
View reviewed changes
roles/setup_acm_agents/README.md Outdated Show resolved Hide resolved
roles/setup_acm_agents/defaults/main.yml Outdated Show resolved Hide resolved
roles/setup_acm_agents/tasks/create-agent.yml Outdated Show resolved Hide resolved
roles/setup_acm_agents/tasks/create-agent.yml Outdated Show resolved Hide resolved
@betoredhat
Copy link
Contributor Author

Thanks @nsilla, I have applied your comments. As it is still a draft and I want to continue doing force push you may not see them in the history. Regards.

@dcibot
Copy link
Collaborator

dcibot commented Oct 4, 2024

from change #455:

  • no check (not a code change)

1 similar comment
@dcibot
Copy link
Collaborator

dcibot commented Oct 4, 2024

from change #455:

  • no check (not a code change)

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/a49f4ededa3e49a8b11bf073f8a42727

✔️ dci-rpm-build-el8 SUCCESS in 2m 47s
✔️ dci-rpm-build-el9 SUCCESS in 2m 15s

@dcibot
Copy link
Collaborator

dcibot commented Oct 8, 2024

from change #455:

  • no check (not a code change)

1 similar comment
@dcibot
Copy link
Collaborator

dcibot commented Oct 8, 2024

from change #455:

  • no check (not a code change)

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/8e829f3b6ccb47a59dc529726d732fa5

✔️ dci-rpm-build-el8 SUCCESS in 2m 47s
✔️ dci-rpm-build-el9 SUCCESS in 2m 22s

@dcibot
Copy link
Collaborator

dcibot commented Oct 9, 2024

from change https://github.com/dci-labs/dallas-pipelines/pull/1243:

@dcibot
Copy link
Collaborator

dcibot commented Oct 10, 2024

from change https://github.com/dci-labs/dallas-pipelines/pull/1243:

@dcibot
Copy link
Collaborator

dcibot commented Oct 10, 2024

from change https://github.com/dci-labs/dallas-pipelines/pull/1243:

@dcibot
Copy link
Collaborator

dcibot commented Oct 10, 2024

from change https://github.com/dci-labs/dallas-pipelines/pull/1243:

@dcibot
Copy link
Collaborator

dcibot commented Oct 10, 2024

from change https://github.com/dci-labs/dallas-pipelines/pull/1243:

@dcibot
Copy link
Collaborator

dcibot commented Oct 10, 2024

from change https://github.com/dci-labs/dallas-pipelines/pull/1243:

@dcibot
Copy link
Collaborator

dcibot commented Oct 11, 2024

from change https://github.com/dci-labs/dallas-pipelines/pull/1243:

@dcibot
Copy link
Collaborator

dcibot commented Oct 16, 2024

from change https://github.com/dci-labs/dallas-pipelines/pull/1243:

@dcibot
Copy link
Collaborator

dcibot commented Oct 16, 2024

from change https://github.com/dci-labs/dallas-pipelines/pull/1243:

@dcibot
Copy link
Collaborator

dcibot commented Oct 16, 2024

from change https://github.com/dci-labs/dallas-pipelines/pull/1243:

@dcibot
Copy link
Collaborator

dcibot commented Oct 16, 2024

from change https://github.com/dci-labs/dallas-pipelines/pull/1243:

@dcibot
Copy link
Collaborator

dcibot commented Oct 16, 2024

from change https://github.com/dci-labs/dallas-pipelines/pull/1243:

Sandeepyadav93
Sandeepyadav93 reviewed Oct 22, 2024
View reviewed changes
roles/setup_acm_agents/README.md
name: setup_acm_agents
vars:
setup_acm_agents_infraenv_name: <InfraN>
setup_acm_agent_inventory:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: missing s after agent

setup_acm_agents_inventory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsilla nsilla nsilla left review comments

@Sandeepyadav93 Sandeepyadav93 Sandeepyadav93 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@betoredhat @dcibot @Sandeepyadav93 @nsilla