fix: detection of changed files that might cause failure on some paths 🍭 #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jamacku
force-pushed
the
debug-debug
branch
3 times, most recently
from
cfe5553
to
3da62ee
Compare
Codecov Report
@@ Coverage Diff @@
## main #286 +/- ##
==========================================
- Coverage 84.00% 82.84% -1.16%
==========================================
Files 4 4
Lines 250 239 -11
==========================================
- Hits 210 198 -12
- Misses 40 41 +1
|
jamacku
force-pushed
the
debug-debug
branch
2 times, most recently
from
4ab657a
to
e4d167c
Compare
jamacku
changed the title
jamacku
changed the title
jamacku
force-pushed
the
debug-debug
branch
3 times, most recently
from
73bc819
to
8936e61
Compare
By using `-z` option of `git diff` we can get the file paths without extra spaces, newlines and quotes. Previously this caused issues like: ```sh + head -n1 '"test/fuzz/fuzz-unit-file/dm-back\\x2dslash.swap"' head: cannot open '"test/fuzz/fuzz-unit-file/dm-back\\x2dslash.swap"' for reading: No such file or directory ```
Since we are using git with `-z` flag, we no longer need `clean_array()` functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using
-zoption ofgit diffwe can get the file paths withoutextra spaces, newlines and quotes. Previously this caused issues like:
clean_array()function is still needed? - A: We don't.